ipng/lcpng
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Sanitize some overly verbose logging ERR->{DBG,INFO}

Browse Source
This commit is contained in:
Pim van Pelt
2021-08-13 21:08:03 +02:00
parent 72f55fd901
commit aab11196cf
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lcpng_if_sync.c
View File

@ -69,7 +69,7 @@ lcp_itf_pair_walk_sync_state_cb (index_t lipi, void *ctx)
clib_setns (vif_ns_fd); clib_setns (vif_ns_fd);
} }
LCP_ITF_PAIR_DBG ("walk_sync_state: lip %U flags %u mtu %u sup-mtu %u", LCP_ITF_PAIR_DBG ("walk_sync_state: %U flags %u mtu %u sup-mtu %u",
format_lcp_itf_pair, lip, sw->flags, sw->mtu[VNET_MTU_L3], format_lcp_itf_pair, lip, sw->flags, sw->mtu[VNET_MTU_L3],
sup_sw->mtu[VNET_MTU_L3]); sup_sw->mtu[VNET_MTU_L3]);
lcp_itf_set_link_state (lip, (sw->flags & VNET_SW_INTERFACE_FLAG_ADMIN_UP)); lcp_itf_set_link_state (lip, (sw->flags & VNET_SW_INTERFACE_FLAG_ADMIN_UP));
@ -79,7 +79,7 @@ lcp_itf_pair_walk_sync_state_cb (index_t lipi, void *ctx)
*/ */
if (sup_sw->mtu[VNET_MTU_L3] < sw->mtu[VNET_MTU_L3]) if (sup_sw->mtu[VNET_MTU_L3] < sw->mtu[VNET_MTU_L3])
{ {
LCP_ITF_PAIR_ERR ("walk_sync_state: lip %U flags %u mtu %u sup-mtu %u: " LCP_ITF_PAIR_ERR ("walk_sync_state: %U flags %u mtu %u sup-mtu %u: "
"clamping to sup-mtu to satisfy netlink", "clamping to sup-mtu to satisfy netlink",
format_lcp_itf_pair, lip, sw->flags, format_lcp_itf_pair, lip, sw->flags,
sw->mtu[VNET_MTU_L3], sup_sw->mtu[VNET_MTU_L3]); sw->mtu[VNET_MTU_L3], sup_sw->mtu[VNET_MTU_L3]);
@ -382,7 +382,7 @@ lcp_itf_ip4_add_del_interface_addr (ip4_main_t *im, uword opaque,
clib_setns (vif_ns_fd); clib_setns (vif_ns_fd);
} }
LCP_ITF_PAIR_ERR ("ip4_addr_%s: %U ip4 %U/%u", is_del ? "del" : "add", LCP_ITF_PAIR_DBG ("ip4_addr_%s: %U ip4 %U/%u", is_del ? "del" : "add",
format_lcp_itf_pair, lip, format_ip4_address, address, format_lcp_itf_pair, lip, format_ip4_address, address,
address_length); address_length);
@ -427,7 +427,7 @@ lcp_itf_ip6_add_del_interface_addr (ip6_main_t *im, uword opaque,
if (vif_ns_fd != -1) if (vif_ns_fd != -1)
clib_setns (vif_ns_fd); clib_setns (vif_ns_fd);
} }
LCP_ITF_PAIR_ERR ("ip6_addr_%s: %U ip4 %U/%u", is_del ? "del" : "add", LCP_ITF_PAIR_DBG ("ip6_addr_%s: %U ip4 %U/%u", is_del ? "del" : "add",
format_lcp_itf_pair, lip, format_ip6_address, address, format_lcp_itf_pair, lip, format_ip6_address, address,
address_length); address_length);
if (is_del) if (is_del)

8
lcpng_interface.c
View File

@ -637,21 +637,21 @@ lcp_itf_set_interface_addr (const lcp_itf_pair_t *lip)
clib_setns (vif_ns_fd); clib_setns (vif_ns_fd);
} }
/* Display any IP4 addressing info */ /* Sync any IP4 addressing info into LCP */
foreach_ip_interface_address ( foreach_ip_interface_address (
lm4, ia, lip->lip_phy_sw_if_index, 1 /* honor unnumbered */, ({ lm4, ia, lip->lip_phy_sw_if_index, 1 /* honor unnumbered */, ({
ip4_address_t *r4 = ip_interface_address_get_address (lm4, ia); ip4_address_t *r4 = ip_interface_address_get_address (lm4, ia);
LCP_ITF_PAIR_ERR ("set_interface_addr: %U add ip4 %U/%d", LCP_ITF_PAIR_INFO ("set_interface_addr: %U add ip4 %U/%d",
format_lcp_itf_pair, lip, format_ip4_address, r4, format_lcp_itf_pair, lip, format_ip4_address, r4,
ia->address_length); ia->address_length);
vnet_netlink_add_ip4_addr (lip->lip_vif_index, r4, ia->address_length); vnet_netlink_add_ip4_addr (lip->lip_vif_index, r4, ia->address_length);
})); }));
/* Display any IP6 addressing info */ /* Sync any IP6 addressing info into LCP */
foreach_ip_interface_address ( foreach_ip_interface_address (
lm6, ia, lip->lip_phy_sw_if_index, 1 /* honor unnumbered */, ({ lm6, ia, lip->lip_phy_sw_if_index, 1 /* honor unnumbered */, ({
ip6_address_t *r6 = ip_interface_address_get_address (lm6, ia); ip6_address_t *r6 = ip_interface_address_get_address (lm6, ia);
LCP_ITF_PAIR_ERR ("set_interface_addr: %U add ip6 %U/%d", LCP_ITF_PAIR_INFO ("set_interface_addr: %U add ip6 %U/%d",
format_lcp_itf_pair, lip, format_ip6_address, r6, format_lcp_itf_pair, lip, format_ip6_address, r6,
ia->address_length); ia->address_length);
vnet_netlink_add_ip6_addr (lip->lip_vif_index, r6, ia->address_length); vnet_netlink_add_ip6_addr (lip->lip_vif_index, r6, ia->address_length);