Merge review feedback from mgsmith on upstream gerrit 33709 ps8..10

This commit is contained in:
Pim van Pelt
2021-11-29 20:04:54 +00:00
parent 6caa5e8386
commit cdf07cce34
6 changed files with 108 additions and 109 deletions

View File

@ -112,8 +112,8 @@ VLIB_CLI_COMMAND(lcp_itf_pair_create_command, static) = {
};
static clib_error_t *
lcp_lcp_sync_command_fn (vlib_main_t *vm, unformat_input_t *input,
vlib_cli_command_t *cmd)
lcp_sync_command_fn (vlib_main_t *vm, unformat_input_t *input,
vlib_cli_command_t *cmd)
{
unformat_input_t _line_input, *line_input = &_line_input;
@ -123,10 +123,10 @@ lcp_lcp_sync_command_fn (vlib_main_t *vm, unformat_input_t *input,
while (unformat_check_input (line_input) != UNFORMAT_END_OF_INPUT)
{
if (unformat (line_input, "on") || unformat (line_input, "enable"))
lcp_set_lcp_sync (1);
lcp_set_sync (1);
else if (unformat (line_input, "off") ||
unformat (line_input, "disable"))
lcp_set_lcp_sync (0);
lcp_set_sync (0);
else
return clib_error_return (0, "unknown input `%U'",
format_unformat_error, line_input);
@ -136,15 +136,15 @@ lcp_lcp_sync_command_fn (vlib_main_t *vm, unformat_input_t *input,
return 0;
}
VLIB_CLI_COMMAND (lcp_lcp_sync_command, static) = {
VLIB_CLI_COMMAND (lcp_sync_command, static) = {
.path = "lcp lcp-sync",
.short_help = "lcp lcp-sync [on|enable|off|disable]",
.function = lcp_lcp_sync_command_fn,
.function = lcp_sync_command_fn,
};
static clib_error_t *
lcp_lcp_auto_subint_command_fn (vlib_main_t *vm, unformat_input_t *input,
vlib_cli_command_t *cmd)
lcp_auto_subint_command_fn (vlib_main_t *vm, unformat_input_t *input,
vlib_cli_command_t *cmd)
{
unformat_input_t _line_input, *line_input = &_line_input;
@ -154,10 +154,10 @@ lcp_lcp_auto_subint_command_fn (vlib_main_t *vm, unformat_input_t *input,
while (unformat_check_input (line_input) != UNFORMAT_END_OF_INPUT)
{
if (unformat (line_input, "on") || unformat (line_input, "enable"))
lcp_set_lcp_auto_subint (1);
lcp_set_auto_subint (1);
else if (unformat (line_input, "off") ||
unformat (line_input, "disable"))
lcp_set_lcp_auto_subint (0);
lcp_set_auto_subint (0);
else
return clib_error_return (0, "unknown input `%U'",
format_unformat_error, line_input);
@ -167,10 +167,10 @@ lcp_lcp_auto_subint_command_fn (vlib_main_t *vm, unformat_input_t *input,
return 0;
}
VLIB_CLI_COMMAND (lcp_lcp_auto_subint_command, static) = {
VLIB_CLI_COMMAND (lcp_auto_subint_command, static) = {
.path = "lcp lcp-auto-subint",
.short_help = "lcp lcp-auto-subint [on|enable|off|disable]",
.function = lcp_lcp_auto_subint_command_fn,
.function = lcp_auto_subint_command_fn,
};
static clib_error_t *lcp_default_netns_command_fn(vlib_main_t *vm,