ipng/lcpng
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

After fixing the feflags/frpflags bug, install specials again

Browse Source
This commit is contained in:
Pim van Pelt
2021-12-24 20:05:08 +00:00
parent 22e907555d
commit fffb1e892a
2 changed files with 2 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

BIN
.lcpng_nl_sync.c.swp Normal file
View File

Binary file not shown.

14
lcpng_nl_sync.c
View File

@ -490,11 +490,7 @@ lcp_nl_route_add (struct rtnl_route *rr)
}; };
rtnl_route_foreach_nexthop (rr, lcp_nl_route_path_parse, &np); rtnl_route_foreach_nexthop (rr, lcp_nl_route_path_parse, &np);
// TODO(pim) - figure out why we have spurious crashes when lcp_nl_route_path_add_special (rr, &np);
// adding a route w/ nexthops {} or nexthops { idx 1 } on an
// empty FIB.
//
// lcp_nl_route_path_add_special (rr, &np);
if (0 != vec_len (np.paths)) if (0 != vec_len (np.paths))
{ {
@ -535,13 +531,7 @@ lcp_nl_route_add (struct rtnl_route *rr)
} }
} }
else else
// TODO(pim) - while the above add_special() is commented out, any NL_WARN ("route_add: no paths table %d prefix %U flags %U netlink %U",
// route inserted tiwh unreach/prohibit/blackhole, for example when VPP
// is restarted, Bird will flip all routes in the RIB to 'unreach', and
// when it rediscovers devices and their connecteds, it will send a whole
// bunch of them back. Ignore for now. When add_special() is fixed, this
// should become a WARN again.
NL_INFO ("route_add: no paths table %d prefix %U flags %U netlink %U",
rtnl_route_get_table (rr), format_fib_prefix, &pfx, rtnl_route_get_table (rr), format_fib_prefix, &pfx,
format_fib_entry_flags, entry_flags, format_nl_object, rr); format_fib_entry_flags, entry_flags, format_nl_object, rr);