Pim van Pelt
224167ce39
Checker / reload:
- Reload's update-in-place branch now mirrors b.Address onto the
runtime health.Backend. Without this, GetBackend kept returning
the pre-reload address indefinitely after a config edit that
touched addresses but not healthcheck settings — the VPP sync
path reads cfg.Backends directly so the dataplane moved on
while the gRPC and SPA view stayed wedged on the old IPv4/IPv6.
Sync (internal/vpp/lbsync.go):
- reconcileVIP now detects encap mismatch in addition to
src-ip-sticky mismatch and takes the full tear-down / re-add
path via a new shared recreateVIP helper. Triggered when every
backend flips address family (gre4 <-> gre6) and the existing
VIP can no longer accept new ASes — previously the sync wedged
with 'Invalid address family' until a full maglevd restart.
- setASWeight is issued whenever the state machine requests
flush (a.Flush=true), not only on the weight-value transition
edge. Fixes the case where a backend reached StateDisabled
after its effective weight had already been drained to 0 by
pool failover — the sticky-cache entries pointing at it were
previously never cleared.
maglev-frontend:
- signal.Ignore(SIGHUP) so a controlling-terminal disconnect
doesn't kill the daemon.
- debian/vpp-maglev.service grants CAP_SYS_ADMIN in addition to
CAP_NET_RAW so setns(CLONE_NEWNET) can join the healthcheck
netns. Comment documents the 'operation not permitted' symptom
and notes the knob can be dropped if the deployment doesn't use
the 'netns:' healthcheck option.
LB plugin counters (internal/vpp/lbstats.go + friends):
- Fix the VIP counter regex: the LB plugin registers
vlib_simple_counter_main_t names without a leading '/'
(vlib_validate_simple_counter in counter.c:50 uses cm->name
verbatim; only entries that set cm->stat_segment_name get a
slash). first/next/untracked/no-server now read through as
live values instead of zero.
- Drop the per-backend FIB counter block end-to-end (proto,
grpcapi, metrics, vpp.Client, lbstats, maglevc). Traced from
lb/node.c:558 into ip{4,6}_forward.h:141 — the LB plugin
forwards by writing adj_index[VLIB_TX] directly and bypassing
ip{4,6}_lookup_inline, which is the only path that increments
lbm_to_counters. The backend's FIB load_balance stats_index
literally never ticks for LB-forwarded traffic, so the column
was always zero and misleading. docs/implementation/TODO
records the full investigation and the recommended upstream
path (new lb_as_stats_dump API message) for when we're ready
to carry that VPP patch.
- maglevc show vpp lb counters: plain-text tabular headers.
label() wraps strings in ANSI escapes (~11 bytes of overhead),
but tabwriter counts bytes, not rendered width — so a header
row with label()'d cells and data rows with plain cells drifts
column alignment on every row. color.go comment now spells
out the constraint: label() only works when column N is
wrapped identically in every row (key-value layouts are fine,
multi-column tables with header-only labelling are not).
SPA:
- stores/scope.ts is cookie-backed (maglev_scope, 1 year,
SameSite=Lax). App.tsx hydrates from the cookie then validates
against the fetched snapshots: a cookie referencing a maglevd
that no longer exists falls through to snaps[0] instead of
leaving the user on a ghost selection.
- components/Flash.tsx wraps props.value in createMemo. Solid's
on() fires its callback on every dep notification, not on
value change — source is right in solid-js/dist/solid.js:460,
no equality check. Without the memo, flipping scope between
two 'connected' maglevds (or any other cross-store reactive
re-eval that doesn't actually change the concrete string)
replays the animation every time. createMemo's default ===
dedupe fixes it in one place for every Flash consumer,
superseding the local createMemo workaround we'd added in
BackendRow earlier.
54 lines
1.8 KiB
TypeScript
54 lines
1.8 KiB
TypeScript
import { createSignal } from "solid-js";
|
|
|
|
// Persistence layer for collapsible (Zippy) panels. The cookie is a
|
|
// best-effort hint: the page always renders all Zippies closed unless
|
|
// their stable id is in the cookie's open-set, but a missing or
|
|
// corrupt cookie just falls back to "everything closed", so losing it
|
|
// (browser data clear, expiry, private window, write failure) is a
|
|
// pure cosmetic regression.
|
|
//
|
|
// localStorage would arguably be a tidier home for this — it's
|
|
// client-only and doesn't ride on every HTTP request — but the
|
|
// payload is tiny and the user asked for a cookie, so a cookie it
|
|
// is. SameSite=Lax keeps it from leaking to third-party iframes.
|
|
|
|
const COOKIE_NAME = "maglev_zippy_open";
|
|
const COOKIE_MAX_AGE = 60 * 60 * 24 * 365; // 1 year
|
|
|
|
function readCookie(): Set<string> {
|
|
try {
|
|
const raw = document.cookie.split("; ").find((c) => c.startsWith(COOKIE_NAME + "="));
|
|
if (!raw) return new Set();
|
|
const value = decodeURIComponent(raw.slice(COOKIE_NAME.length + 1));
|
|
if (!value) return new Set();
|
|
return new Set(value.split(","));
|
|
} catch {
|
|
return new Set();
|
|
}
|
|
}
|
|
|
|
function writeCookie(ids: Set<string>) {
|
|
try {
|
|
const value = encodeURIComponent([...ids].join(","));
|
|
document.cookie = `${COOKIE_NAME}=${value}; Path=/; Max-Age=${COOKIE_MAX_AGE}; SameSite=Lax`;
|
|
} catch {
|
|
// best-effort — quota, third-party-cookie blocks, etc. all silently fall back
|
|
}
|
|
}
|
|
|
|
const [openSet, setOpenSet] = createSignal<Set<string>>(readCookie());
|
|
|
|
export function isZippyOpen(id: string): boolean {
|
|
return openSet().has(id);
|
|
}
|
|
|
|
export function setZippyOpen(id: string, open: boolean) {
|
|
const cur = openSet();
|
|
if (open === cur.has(id)) return;
|
|
const next = new Set(cur);
|
|
if (open) next.add(id);
|
|
else next.delete(id);
|
|
setOpenSet(next);
|
|
writeCookie(next);
|
|
}
|