From 09a2b6e9e478d650f432861e5f01a3f07fe13be9 Mon Sep 17 00:00:00 2001
From: Pim van Pelt <pim@ipng.nl>
Date: Wed, 15 Sep 2021 07:56:50 +0000
Subject: [PATCH] Remove logger from dataset, it's not necessary, as there's
 only one call location that wants to say something. Turn that into an
 exception instead

---
 agentx/dataset.py | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/agentx/dataset.py b/agentx/dataset.py
index c385721..06f141d 100644
--- a/agentx/dataset.py
+++ b/agentx/dataset.py
@@ -8,19 +8,13 @@ from __future__ import (
 
 import time
 import agentx
-import logging
-
-
-class NullHandler(logging.Handler):
-    def emit(self, record):
-        pass
 
+class DataSetError(Exception):
+    pass
 
 class DataSet():
     def __init__(self):
         self._data = {}
-        self.logger = logging.getLogger('agentx.dataset')
-        self.logger.addHandler(NullHandler())
 
     def set(self, oid, oid_type, value):
         if oid_type.startswith('int'):
@@ -42,7 +36,7 @@ class DataSet():
         elif oid_type == 'counter64' or oid_type == 'uint64' or oid_type == 'u64':
             t = agentx.TYPE_COUNTER64
         else:
-            self.logger.error('Invalid oid_type: %s' % (oid_type))
+            raise DataSetErrror('Invalid oid_type: %s' % (oid_type))
             return
 
         self._data[oid] = {