From 14cd365ad3e34750596ea07a66046a79113929b6 Mon Sep 17 00:00:00 2001 From: Pim van Pelt Date: Sun, 20 Mar 2022 22:01:51 +0000 Subject: [PATCH] Move LCP tests to their own test_*py file --- validator/test_interface.py | 6 ------ validator/test_lcp.py | 15 +++++++++++++++ 2 files changed, 15 insertions(+), 6 deletions(-) create mode 100644 validator/test_lcp.py diff --git a/validator/test_interface.py b/validator/test_interface.py index 6a47c6b..ab3c8b4 100644 --- a/validator/test_interface.py +++ b/validator/test_interface.py @@ -1,7 +1,6 @@ import unittest import yaml import validator.interface as interface -import validator.lcp as lcp class TestInterfaceMethods(unittest.TestCase): def setUp(self): @@ -77,11 +76,6 @@ class TestInterfaceMethods(unittest.TestCase): self.assertEqual(interface.get_lcp(self.cfg, "GigabitEthernet1/0/1"), "e1") self.assertEqual(interface.get_lcp(self.cfg, "GigabitEthernet1/0/1.100"), "foo") - self.assertTrue(lcp.is_unique(self.cfg, "e1")) - self.assertTrue(lcp.is_unique(self.cfg, "foo")) - - ## TODO(pim) - ensure that is_unique also takes synthesized LCPs into account - ## self.assertFalse(lcp.is_unique(self.cfg, "e1.1000")) self.assertEqual(interface.get_lcp(self.cfg, "GigabitEthernet1/0/1.200"), "e1.1000") self.assertEqual(interface.get_lcp(self.cfg, "GigabitEthernet1/0/1.201"), "e1.1000") diff --git a/validator/test_lcp.py b/validator/test_lcp.py new file mode 100644 index 0000000..8682eff --- /dev/null +++ b/validator/test_lcp.py @@ -0,0 +1,15 @@ +import unittest +import yaml +import validator.lcp as lcp + +class TestInterfaceMethods(unittest.TestCase): + def setUp(self): + with open("unittest/TestInterfaceMethods.yaml", "r") as f: + self.cfg = yaml.load(f, Loader = yaml.FullLoader) + + def test_lcp(self): + self.assertTrue(lcp.is_unique(self.cfg, "e1")) + self.assertTrue(lcp.is_unique(self.cfg, "foo")) + + ## TODO(pim) - ensure that is_unique also takes synthesized LCPs into account + ## self.assertFalse(lcp.is_unique(self.cfg, "e1.1000"))