Add a full set of get_*_by_name() tests

validator/test_bondethernet.py

@@ -7,6 +7,14 @@ class TestBondEthernetMethods(unittest.TestCase):
         with open("unittest/test_bondethernet.yaml", "r") as f:
             self.cfg = yaml.load(f, Loader = yaml.FullLoader)
 
+    def test_get_by_name(self):
+        ifname, iface = bondethernet.get_by_name(self.cfg, "BondEthernet0")
+        self.assertIsNotNone(iface)
+        self.assertEqual("BondEthernet0", ifname)
+        self.assertIn("GigabitEthernet1/0/0", iface['interfaces'])
+        self.assertNotIn("GigabitEthernet2/0/0", iface['interfaces'])
+
+
     def test_members(self):
         self.assertTrue(bondethernet.is_bond_member(self.cfg, "GigabitEthernet1/0/0"))
         self.assertTrue(bondethernet.is_bond_member(self.cfg, "GigabitEthernet1/0/1"))

validator/test_bridgedomain.py

@@ -7,6 +7,13 @@ class TestBridgeDomainMethods(unittest.TestCase):
         with open("unittest/test_bridgedomain.yaml", "r") as f:
             self.cfg = yaml.load(f, Loader = yaml.FullLoader)
 
+    def test_get_by_name(self):
+        ifname, iface = bridgedomain.get_by_name(self.cfg, "bd10")
+        self.assertIsNotNone(iface)
+        self.assertEqual("bd10", ifname)
+        self.assertEqual(iface['mtu'], 3000)
+        self.assertIn("BondEthernet0", iface['interfaces'])
+
     def test_members(self):
         self.assertTrue(bridgedomain.is_bridge_interface(self.cfg, "GigabitEthernet1/0/0"))
         self.assertTrue(bridgedomain.is_bridge_interface(self.cfg, "GigabitEthernet2/0/0.100"))

validator/test_interface.py

@@ -87,7 +87,11 @@ class TestInterfaceMethods(unittest.TestCase):
         self.assertTrue(interface.is_qinx(self.cfg, "GigabitEthernet1/0/1.201"))
         self.assertTrue(interface.is_qinx(self.cfg, "GigabitEthernet1/0/1.203"))
 
-    def test_lcp(self):
+    def test_has_lcp(self):
+        self.assertTrue(interface.has_lcp(self.cfg, "GigabitEthernet1/0/1"))
+        self.assertFalse(interface.has_lcp(self.cfg, "GigabitEthernet1/0/0"))
+
+    def test_get_lcp(self):
         self.assertIsNone(interface.get_lcp(self.cfg, "GigabitEthernet1/0/0"))
         self.assertIsNone(interface.get_lcp(self.cfg, "GigabitEthernet1/0/0.100"))
 
@@ -132,7 +136,29 @@ class TestInterfaceMethods(unittest.TestCase):
         self.assertTrue(interface.is_l3(self.cfg, "GigabitEthernet1/0/0"))
         self.assertFalse(interface.is_l3(self.cfg, "GigabitEthernet3/0/0"))
 
-    def test_qinx_parent(self):
+    def test_get_by_name(self):
+        ifname, iface = interface.get_by_name(self.cfg, "GigabitEthernet1/0/1.201")
+        self.assertEqual(ifname, "GigabitEthernet1/0/1.201")
+        self.assertIsNotNone(iface)
+        encap = interface.get_encapsulation(self.cfg, ifname)
+        self.assertEqual(encap, {'dot1q': 1000, 'dot1ad': 0, 'inner-dot1q': 1234, 'exact-match': False})
+
+    def test_get_parent_by_name(self):
+        ifname, iface = interface.get_parent_by_name(self.cfg, "GigabitEthernet1/0/1.201")
+        self.assertEqual(ifname, "GigabitEthernet1/0/1")
+        self.assertIsNotNone(iface)
+        self.assertNotIn('encapsulation', iface)
+
+        ifname, iface = interface.get_parent_by_name(self.cfg, "GigabitEthernet1/0/1.200")
+        self.assertEqual(ifname, "GigabitEthernet1/0/1")
+        self.assertIsNotNone(iface)
+        self.assertNotIn('encapsulation', iface)
+
+        ifname, iface = interface.get_parent_by_name(self.cfg, "GigabitEthernet1/0/1")
+        self.assertIsNone(ifname)
+        self.assertIsNone(iface)
+
+    def test_get_qinx_parent_by_name(self):
         self.assertIsNotNone(interface.get_qinx_parent_by_name(self.cfg, "GigabitEthernet1/0/1.202"))
         self.assertIsNotNone(interface.get_qinx_parent_by_name(self.cfg, "GigabitEthernet1/0/1.203"))