diff --git a/unittest/correct-empty2.yaml b/unittest/correct-empty2.yaml new file mode 100644 index 0000000..1d39dac --- /dev/null +++ b/unittest/correct-empty2.yaml @@ -0,0 +1,9 @@ +test: + description: "A completely empty config file is, ironically, correct" + errors: + count: 0 +--- +interfaces: {} +loopbacks: {} +bridgedomains: {} +bondethernets: {} diff --git a/validator/__init__.py b/validator/__init__.py index 13f62af..c554b6f 100644 --- a/validator/__init__.py +++ b/validator/__init__.py @@ -121,4 +121,6 @@ class Validator(object): if not rv: ret_rv = False + if ret_rv: + self.logger.debug("Semantics correctly validated") return ret_rv, ret_msgs diff --git a/validator/bridgedomain.py b/validator/bridgedomain.py index e13d1ec..ac606b6 100644 --- a/validator/bridgedomain.py +++ b/validator/bridgedomain.py @@ -40,7 +40,6 @@ def validate_bridgedomains(yaml): if not 'bridgedomains' in yaml: return result, msgs - logger.debug("Validating bridgedomains...") for ifname, iface in yaml['bridgedomains'].items(): logger.debug("bridgedomain %s" % iface) bd_mtu = 1500 diff --git a/validator/loopback.py b/validator/loopback.py index 978edf5..b6bfee1 100644 --- a/validator/loopback.py +++ b/validator/loopback.py @@ -38,7 +38,6 @@ def validate_loopbacks(yaml): if not 'loopbacks' in yaml: return result, msgs - logger.debug("Validating loopbacks...") for ifname, iface in yaml['loopbacks'].items(): logger.debug("loopback %s" % iface) if 'addresses' in iface and not 'lcp' in iface: