ipng/vppcfg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ensure that LCP names are globally unique (between interface/sub-interface/loopback/bridgedomain)

Browse Source
This commit is contained in:
Pim van Pelt
2022-03-13 19:53:13 +00:00
parent 0d8a28cadd
commit 763c1ca74c
7 changed files with 85 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
validator/interface.py
View File

@ -1,5 +1,6 @@
import logging
import validator.bondethernet as bondethernet
import validator.lcp as lcp
class NullHandler(logging.Handler):
def emit(self, record):
@ -18,6 +19,7 @@ def get_parent_by_name(yaml, ifname):
pass
return None
def get_by_name(yaml, ifname):
""" Returns the interface or sub-interface by a given name, or None if it does not exist """
if '.' in ifname:
@ -84,25 +86,6 @@ def is_bond_member(yaml, ifname):
return True
return False
def unique_lcp(yaml, ifname):
""" Returns true if this interface has a unique LCP name """
if not 'interfaces' in yaml:
return True
iface = get_by_name(yaml, ifname)
lcp = get_lcp(yaml, ifname)
if not lcp:
return True
ncount = 0
for sibling_ifname, sibling_iface in yaml['interfaces'].items():
sibling_lcp = get_lcp(yaml, sibling_ifname)
if sibling_lcp == lcp and sibling_ifname != ifname:
## print("%s overlaps with %s: %s" % (ifname, sibling_ifname, lcp))
ncount = ncount + 1
if ncount == 0:
return True
return False
def has_lcp(yaml, ifname):
""" Returns True if this interface or sub-interface has an LCP"""
if not 'interfaces' in yaml:
@ -282,9 +265,9 @@ def validate_interfaces(yaml):
if iface_address and not iface_lcp:
msgs.append("interface %s has an address but no LCP" % ifname)
result = False
if iface_lcp and not unique_lcp(yaml, ifname):
lcp = get_lcp(yaml, ifname)
msgs.append("interface %s does not have a unique LCP name %s" % (ifname, lcp))
iface_lcp = get_lcp(yaml, ifname)
if iface_lcp and not lcp.is_unique(yaml, iface_lcp):
msgs.append("interface %s does not have a unique LCP name %s" % (ifname, iface_lcp))
result = False
if has_sub(yaml, ifname):
@ -300,6 +283,9 @@ def validate_interfaces(yaml):
if sub_lcp and len(sub_lcp)>15:
msgs.append("sub-interface %s has LCP with too long name '%s'" % (sub_ifname, sub_lcp))
result = False
if iface_lcp and not lcp.is_unique(yaml, iface_lcp):
msgs.append("sub-interface %s does not have a unique LCP name %s" % (sub_ifname, sub_lcp))
result = False
sub_mtu = get_mtu(yaml, sub_ifname)
if sub_mtu > iface_mtu:
msgs.append("sub-interface %s has MTU %d higher than parent MTU %d" % (sub_ifname, sub_iface['mtu'], iface_mtu))