ipng/vppcfg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Assert get_by_name() with non-existent name returns a tuple of None,None

Browse Source
This commit is contained in:
Pim van Pelt
2022-03-22 18:31:03 +00:00
parent 5ecd1ef22c
commit 97fef9bfd2
3 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
validator/test_bondethernet.py
View File

@ -14,6 +14,9 @@ class TestBondEthernetMethods(unittest.TestCase):
self.assertIn("GigabitEthernet1/0/0", iface['interfaces']) self.assertIn("GigabitEthernet1/0/0", iface['interfaces'])
self.assertNotIn("GigabitEthernet2/0/0", iface['interfaces']) self.assertNotIn("GigabitEthernet2/0/0", iface['interfaces'])
ifname, iface = bondethernet.get_by_name(self.cfg, "BondEthernet-notexist")
self.assertIsNone(iface)
self.assertIsNone(ifname)
def test_members(self): def test_members(self):
self.assertTrue(bondethernet.is_bond_member(self.cfg, "GigabitEthernet1/0/0")) self.assertTrue(bondethernet.is_bond_member(self.cfg, "GigabitEthernet1/0/0"))

4
validator/test_bridgedomain.py
View File

@ -14,6 +14,10 @@ class TestBridgeDomainMethods(unittest.TestCase):
self.assertEqual(iface['mtu'], 3000) self.assertEqual(iface['mtu'], 3000)
self.assertIn("BondEthernet0", iface['interfaces']) self.assertIn("BondEthernet0", iface['interfaces'])
ifname, iface = bridgedomain.get_by_name(self.cfg, "bd-notexist")
self.assertIsNone(iface)
self.assertIsNone(ifname)
def test_members(self): def test_members(self):
self.assertTrue(bridgedomain.is_bridge_interface(self.cfg, "GigabitEthernet1/0/0")) self.assertTrue(bridgedomain.is_bridge_interface(self.cfg, "GigabitEthernet1/0/0"))
self.assertTrue(bridgedomain.is_bridge_interface(self.cfg, "GigabitEthernet2/0/0.100")) self.assertTrue(bridgedomain.is_bridge_interface(self.cfg, "GigabitEthernet2/0/0.100"))

4
validator/test_interface.py
View File

@ -143,6 +143,10 @@ class TestInterfaceMethods(unittest.TestCase):
encap = interface.get_encapsulation(self.cfg, ifname) encap = interface.get_encapsulation(self.cfg, ifname)
self.assertEqual(encap, {'dot1q': 1000, 'dot1ad': 0, 'inner-dot1q': 1234, 'exact-match': False}) self.assertEqual(encap, {'dot1q': 1000, 'dot1ad': 0, 'inner-dot1q': 1234, 'exact-match': False})
ifname, iface = interface.get_by_name(self.cfg, "GigabitEthernet1/0/1.1")
self.assertIsNone(ifname)
self.assertIsNone(iface)
def test_get_parent_by_name(self): def test_get_parent_by_name(self):
ifname, iface = interface.get_parent_by_name(self.cfg, "GigabitEthernet1/0/1.201") ifname, iface = interface.get_parent_by_name(self.cfg, "GigabitEthernet1/0/1.201")
self.assertEqual(ifname, "GigabitEthernet1/0/1") self.assertEqual(ifname, "GigabitEthernet1/0/1")