ipng/vppcfg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor for *_get_by_name()

Browse Source 
They now all return a list [ifname, iface]. If no interface was found
they return None,None. If one was found, they return the (string) name
and the dictionary with interface contents.
This commit is contained in:
Pim van Pelt
2022-03-21 01:18:03 +00:00
parent 5247e3a241
commit ba22b1aad8
8 changed files with 84 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
validator/bondethernet.py
View File

@ -20,13 +20,13 @@ class NullHandler(logging.Handler):
def get_by_name(yaml, ifname):
""" Return the BondEthernet by name, if it exists. Return None otherwise. """
""" Return the BondEthernet by name, if it exists. Return None,None otherwise. """
try:
if ifname in yaml['bondethernets']:
return yaml['bondethernets'][ifname]
return ifname, yaml['bondethernets'][ifname]
except:
pass
return None
return None, None
def is_bond_member(yaml, ifname):
@ -54,7 +54,7 @@ def validate_bondethernets(yaml):
for ifname, iface in yaml['bondethernets'].items():
logger.debug("bondethernet %s: %s" % (ifname, iface))
for member in iface['interfaces']:
if not interface.get_by_name(yaml, member):
if (None, None) == interface.get_by_name(yaml, member):
msgs.append("bondethernet %s member %s does not exist" % (ifname, member))
result = False