Refactor for *_get_by_name()

They now all return a list [ifname, iface]. If no interface was found
they return None,None. If one was found, they return the (string) name
and the dictionary with interface contents.
This commit is contained in:
Pim van Pelt
2022-03-21 01:18:03 +00:00
parent 5247e3a241
commit ba22b1aad8
8 changed files with 84 additions and 61 deletions

View File

@ -16,9 +16,9 @@ class TestLCPMethods(unittest.TestCase):
## self.assertFalse(lcp.is_unique(self.cfg, "e1.1000"))
def test_qinx(self):
qinq_iface = interface.get_by_name(self.cfg, "GigabitEthernet1/0/1.201")
mid_iface = interface.get_qinx_parent_by_name(self.cfg, "GigabitEthernet1/0/1.201")
parent_iface = interface.get_parent_by_name(self.cfg, "GigabitEthernet1/0/1.201")
qint_ifname, qinq_iface = interface.get_by_name(self.cfg, "GigabitEthernet1/0/1.201")
mid_ifname, mid_iface = interface.get_qinx_parent_by_name(self.cfg, "GigabitEthernet1/0/1.201")
parent_ifname, parent_iface = interface.get_parent_by_name(self.cfg, "GigabitEthernet1/0/1.201")
# TODO(pim) - complete once get_*_by_name() returns a dict
# print("qinq", qinq_iface)