From c190dfbd2bdde8e53dec1bb9428e14c4212d0083 Mon Sep 17 00:00:00 2001
From: Pim van Pelt <pim@ipng.nl>
Date: Mon, 16 Jan 2023 20:57:49 +0000
Subject: [PATCH] Add a warning in case the tag contains ' or " characters

---
 vppcfg/vpp/dumper.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/vppcfg/vpp/dumper.py b/vppcfg/vpp/dumper.py
index c3faebf..15cd7b4 100644
--- a/vppcfg/vpp/dumper.py
+++ b/vppcfg/vpp/dumper.py
@@ -251,7 +251,12 @@ class Dumper(VPPApi):
         for idx, acl in self.cache["acls"].items():
             aclname = f"vppacl{acl.acl_index}"
 
-            descr = "tag " + acl.tag.replace('"', "").replace("'", "")
+            descr = acl.tag.replace('"', "").replace("'", "")
+            if descr != acl.tag:
+                self.logger.warning(
+                    f"acl tag {acl.tag} has invalid characters, stripping"
+                )
+            descr = "tag " + descr
             config_acl = {"description": descr, "terms": []}
             terms = 0
             for acl_rule in acl.r: