ipng/vppcfg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
97 Commits 1 Branch 0 Tags
0ab907f15595c365521fe38c568d0319a5dbb8ab
Commit Graph

65 Commits

Author SHA1 Message Date
Pim van Pelt
0ab907f155 Add get_bridgedomains() 2022-03-22 18:57:45 +00:00
Pim van Pelt
27ce2351c7 Cosmetic: use '.. LCP' consistently 2022-03-22 18:49:31 +00:00
Pim van Pelt
97fef9bfd2 Assert get_by_name() with non-existent name returns a tuple of None,None 2022-03-22 18:31:03 +00:00
Pim van Pelt
5ecd1ef22c Add unit tests for loopbacks; While here, fix a bug in get_by_name(), yaay 2022-03-22 18:03:38 +00:00
Pim van Pelt
36fbbf9b35 Add a full set of get_*_by_name() tests 2022-03-22 17:53:40 +00:00
Pim van Pelt
7303adb74a Assert is_l2() on sub-ints cannot have address or LCP 2022-03-22 15:02:38 +00:00
Pim van Pelt
077d49cb88 Assert that is_l2() interfaces cannot have LCP or address; Fix consistency on 'be' vs 'have' an LCP. 2022-03-22 14:54:09 +00:00
Pim van Pelt
6688c6b243 Add the case of the ifname being the source of an l2xc to the is_l2() logic1 
This is more strict than VPP itself, which does allow a destination to
be L3 while the source is L2:

DBGvpp# show mode
l3 local0
l3 GigabitEthernet3/0/0
l3 GigabitEthernet3/0/1
l3 HundredGigabitEthernet12/0/0
l3 HundredGigabitEthernet12/0/1

DBGvpp# set interface l2 xconnect GigabitEthernet3/0/0 GigabitEthernet3/0/1

DBGvpp# show mode
l3 local0
l2 xconnect GigabitEthernet3/0/0 GigabitEthernet3/0/1
l3 GigabitEthernet3/0/1
l3 HundredGigabitEthernet12/0/0
l3 HundredGigabitEthernet12/0/1

But it seems undesirable to have Gi3/0/1 be in l3 mode even though it's
the target of a cross connect, so I'm going to leave the behavior
stricter than VPP.
 2022-03-22 14:21:32 +00:00
Pim van Pelt
5ebaf5e005 Add optional filtering of get_lcps() based on type of interface 2022-03-22 14:17:36 +00:00
Pim van Pelt
907412f49c Fix bug in get_l2xc_interfaces(), and add tests for it 2022-03-22 13:15:21 +00:00
Pim van Pelt
7ae82c297c Add get_lcps() to enumerate all LCP names in the system 2022-03-22 13:04:56 +00:00
Pim van Pelt
c18f04fa55 Refactor: stop trying to derive implicit LCP names. Make it mandatory and explicitly configured 2022-03-21 11:06:15 +00:00
Pim van Pelt
58d0ebe71e Complete test_qinx now that get_*_by_name() returns tuples 2022-03-21 08:53:40 +00:00
Pim van Pelt
ba22b1aad8 Refactor for *_get_by_name() 
They now all return a list [ifname, iface]. If no interface was found
they return None,None. If one was found, they return the (string) name
and the dictionary with interface contents.
 2022-03-21 08:47:05 +00:00
Pim van Pelt
5247e3a241 Add the beginning of a test_qinx() suite, will complete after a refactor in an upcoming commit 2022-03-20 23:32:59 +00:00
Pim van Pelt
e44db47989 Add interface.get_qinx_parent_by_name() 2022-03-20 23:10:54 +00:00
Pim van Pelt
c55fe93e16 Add unit tests for bridgedomain - move is_bridge_interface*() functions to validator/bridgedomain.py 2022-03-20 22:45:07 +00:00
Pim van Pelt
47757b702c Correct name for LCP tests 2022-03-20 22:17:56 +00:00
Pim van Pelt
1f07f7eadf Add unit tests for bondethernet 2022-03-20 22:17:41 +00:00
Pim van Pelt
31c3d13c12 Isolate LCP into its own tests 2022-03-20 22:04:49 +00:00
Pim van Pelt
14cd365ad3 Move LCP tests to their own test_*py file 2022-03-20 22:01:51 +00:00
Pim van Pelt
459346878a Move to assertEqual 2022-03-20 21:54:28 +00:00
Pim van Pelt
8445140842 Add unittests for validator/interface.py 2022-03-20 21:49:08 +00:00
Pim van Pelt
dbd7bca8f3 Add get_encapsulation; refactor unique_encapsulation to use it. All tests pass. 2022-03-20 16:45:03 +00:00
Pim van Pelt
f921b1721a Expand autocreated LCP namelen to all possible (dot1q, qin*) scenarios. Allow manually set LCP to be 15char in length 2022-03-17 00:15:18 +00:00
Pim van Pelt
3663a04cde Bugfix: check sub_iface instead of iface 2022-03-16 23:57:47 +00:00
Pim van Pelt
6b6207f028 define 'is_l2' the same way VPP does: in a bridge or as an L2XC target. 2022-03-16 23:16:46 +00:00
Pim van Pelt
ccfb51189a A few small refactors, using get_by_name() more, casting boolean return values, etc 2022-03-16 22:20:51 +00:00
Pim van Pelt
252fa989b2 Assert VXLAN local/remote is the same address family. Assert VXLAN VNI is unique. 2022-03-15 22:57:09 +00:00
Pim van Pelt
1e5b1e49ad Assert that an interface cannot l2 cross connect to itself 2022-03-15 22:36:48 +00:00
Pim van Pelt
e7e3958ceb Assert source/target L2XC are the same MTU 2022-03-15 22:32:55 +00:00
Pim van Pelt
686cd45158 Add first approximation of vxlan_tunnels 2022-03-15 22:21:36 +00:00
Pim van Pelt
05b3c5c157 Small refactor, to allow for more interface types to be added as l2xc targets later 2022-03-15 21:56:29 +00:00
Pim van Pelt
af90b37a33 bugfix: Use sub-interface name 2022-03-15 21:52:44 +00:00
Pim van Pelt
2947bbfd25 Get rid of ' characters in errors 2022-03-15 21:13:42 +00:00
Pim van Pelt
2bbcff2ca0 Also assert that targets of an L2XC do not have an address or LCP 2022-03-15 21:07:47 +00:00
Pim van Pelt
5876465327 A few cosmetic changes in logging 2022-03-15 20:57:11 +00:00
Pim van Pelt
6d3de72c00 A completely empty config is a valid config 2022-03-15 20:52:09 +00:00
Pim van Pelt
c5872880fe Add l2xc support, including extensive tests to validate correct usage of the feature 2022-03-15 20:45:27 +00:00
Pim van Pelt
b9a7bb697e Add validator to ensure that bridgedomain interfaces occur in at most one bridgedomain. Ironically, this caught a bug in the bridgedomain5 test, where Gi1/0/0 was added twice. 2022-03-15 19:48:32 +00:00
Pim van Pelt
13f211f27a Make clearer that 'is not allowed' actually means that the address conflicts with another 2022-03-14 00:18:46 +00:00
Pim van Pelt
bb57ed8e52 IP Address validator 
Returns True if there is at most one occurence of the ip_interface (an IPv4/IPv6 prefix+len)
in the entire config. That said, we need the 'iface_addresses' because VPP is a bit fickle in
this regard.

IP addresses from the same prefix/len can be added to a given interface (ie 192.0.2.1/24 and
192.0.2.2/24), but other than that, any prefix can not occur as a more-specific or less-specific
of any other interface.

So, we will allow:
- any ip_interface that is of equal network/len of existing one(s) _on the same interface_

And, we will reject
- any ip_interface that is a more specific of any existing one
- any ip_interface that is a less specific of any existing one

Update unit tests to ensure ip_interfaces are allowed in all cases.
 2022-03-13 23:50:10 +00:00
Pim van Pelt
5c61259edd Add copyright and license 2022-03-13 21:08:32 +00:00
Pim van Pelt
2ca7cc3f11 Check for fields that are of the wrong type. Fix bug in ip_interface() validator thanks to this unittest 2022-03-13 20:20:14 +00:00
Pim van Pelt
763c1ca74c Ensure that LCP names are globally unique (between interface/sub-interface/loopback/bridgedomain) 2022-03-13 19:53:13 +00:00
Pim van Pelt
0d8a28cadd Enforce that when a bridgedomain has an address (ie a BVI), that it must also have an LCP 2022-03-13 19:32:30 +00:00
Pim van Pelt
8825984d49 Force loopbacks with an address to have an LCP 2022-03-13 19:27:27 +00:00
Pim van Pelt
1340e5db42 Remove the attempted plural 'address(es)', and keep it singular. Fix a typo (addd-ress); update unit tests 2022-03-13 19:08:45 +00:00
Pim van Pelt
527b1ca95b Add a set of bridgedomain unit tests, including a fully formed correct one. Fix one bug found along the way! 2022-03-13 18:55:00 +00:00
Pim van Pelt
6ce6718b34 Typofix 2022-03-13 18:35:44 +00:00