2003a21068
Fold in the qinx, 1-tag sub, and phy/lookback into one loop, reducing total LOC by 3x. Tested by running a hippo integration test (ie 169 config-to-config transitions), with no material diffs between the old and the new code: @@ -182,9 +182,9 @@ /tmp/vppcfg-exec_hippo1.yaml: lcp create HundredGigabitEthernet12/0/0.1235 host-if ice0.1234.1000 /tmp/vppcfg-exec_hippo1.yaml_hippo10.yaml: lcp delete HundredGigabitEthernet12/0/0.1235 /tmp/vppcfg-exec_hippo1.yaml_hippo10.yaml: lcp delete HundredGigabitEthernet12/0/0.1234 -/tmp/vppcfg-exec_hippo1.yaml_hippo10.yaml: lcp delete loop1 -/tmp/vppcfg-exec_hippo1.yaml_hippo10.yaml: lcp delete loop0 /tmp/vppcfg-exec_hippo1.yaml_hippo10.yaml: lcp delete HundredGigabitEthernet12/0/0 +/tmp/vppcfg-exec_hippo1.yaml_hippo10.yaml: lcp delete loop0 +/tmp/vppcfg-exec_hippo1.yaml_hippo10.yaml: lcp delete loop1 /tmp/vppcfg-exec_hippo1.yaml_hippo11.yaml: lcp delete HundredGigabitEthernet12/0/0.1235 /tmp/vppcfg-exec_hippo1.yaml_hippo11.yaml: lcp delete HundredGigabitEthernet12/0/0.1234 /tmp/vppcfg-exec_hippo1.yaml_hippo11.yaml: lcp delete loop1 @@ -202,8 +202,8 @@ /tmp/vppcfg-exec_hippo1.yaml_hippo2.yaml: lcp delete HundredGigabitEthernet12/0/0.1235 /tmp/vppcfg-exec_hippo1.yaml_hippo2.yaml: lcp delete HundredGigabitEthernet12/0/0.1234 /tmp/vppcfg-exec_hippo1.yaml_hippo2.yaml: lcp delete loop1 -/tmp/vppcfg-exec_hippo1.yaml_hippo2.yaml: lcp delete loop0 /tmp/vppcfg-exec_hippo1.yaml_hippo2.yaml: lcp delete BondEthernet0 +/tmp/vppcfg-exec_hippo1.yaml_hippo2.yaml: lcp delete loop0 /tmp/vppcfg-exec_hippo1.yaml_hippo2.yaml: lcp delete HundredGigabitEthernet12/0/0 /tmp/vppcfg-exec_hippo1.yaml_hippo3.yaml: lcp delete HundredGigabitEthernet12/0/0.1235 /tmp/vppcfg-exec_hippo1.yaml_hippo3.yaml: lcp delete HundredGigabitEthernet12/0/0.1234