850b982f2a
The handling of BVI is awkward, with the autoderived interface name "bviXX" based on the bridgedomain bd_id. Lots of special casing happens on account of this decision, and to make matters worse there is poor interaction (leading to VPP crashes) when BVIs and Loopbacks are used at the same time: https://lists.fd.io/g/vpp-dev/message/21116 This is step one of a refactor of the logic. In this commit, I'm removing all of the BVI logic from the codebase, rendering bridgedomains unable to have IP interfaces. In the next commit, I will introduce new behavior in the schema, allowing for 'bvi' to be a loopback interfacename which will be used as BVI for a bridgedomain, restoring the ability to use bridgedomains with IP interfaces (using a loop).
47 lines
2.0 KiB
Python
47 lines
2.0 KiB
Python
import unittest
|
|
import yaml
|
|
import config.bridgedomain as bridgedomain
|
|
|
|
class TestBridgeDomainMethods(unittest.TestCase):
|
|
def setUp(self):
|
|
with open("unittest/test_bridgedomain.yaml", "r") as f:
|
|
self.cfg = yaml.load(f, Loader = yaml.FullLoader)
|
|
|
|
def test_get_by_name(self):
|
|
ifname, iface = bridgedomain.get_by_name(self.cfg, "bd10")
|
|
self.assertIsNotNone(iface)
|
|
self.assertEqual("bd10", ifname)
|
|
self.assertEqual(iface['mtu'], 3000)
|
|
self.assertIn("BondEthernet0", iface['interfaces'])
|
|
|
|
ifname, iface = bridgedomain.get_by_name(self.cfg, "bd-notexist")
|
|
self.assertIsNone(iface)
|
|
self.assertIsNone(ifname)
|
|
|
|
def test_is_bridgedomain(self):
|
|
self.assertTrue(bridgedomain.is_bridgedomain(self.cfg, "bd10"))
|
|
self.assertTrue(bridgedomain.is_bridgedomain(self.cfg, "bd11"))
|
|
self.assertFalse(bridgedomain.is_bridgedomain(self.cfg, "bd-notexist"))
|
|
self.assertFalse(bridgedomain.is_bridgedomain(self.cfg, "GigabitEthernet1/0/0"))
|
|
|
|
def test_members(self):
|
|
self.assertTrue(bridgedomain.is_bridge_interface(self.cfg, "GigabitEthernet1/0/0"))
|
|
self.assertTrue(bridgedomain.is_bridge_interface(self.cfg, "GigabitEthernet2/0/0.100"))
|
|
self.assertFalse(bridgedomain.is_bridge_interface(self.cfg, "GigabitEthernet3/0/0"))
|
|
self.assertFalse(bridgedomain.is_bridge_interface(self.cfg, "GigabitEthernet3/0/0.100"))
|
|
|
|
def test_unique(self):
|
|
self.assertFalse(bridgedomain.is_bridge_interface_unique(self.cfg, "GigabitEthernet1/0/0"))
|
|
self.assertTrue(bridgedomain.is_bridge_interface_unique(self.cfg, "GigabitEthernet2/0/0.100"))
|
|
|
|
def test_enumerators(self):
|
|
ifs = bridgedomain.get_bridge_interfaces(self.cfg)
|
|
self.assertEqual(len(ifs), 8)
|
|
self.assertIn("BondEthernet0", ifs)
|
|
self.assertIn("GigabitEthernet1/0/0", ifs)
|
|
self.assertIn("GigabitEthernet2/0/0.100", ifs)
|
|
|
|
def test_get_bridgedomains(self):
|
|
ifs = bridgedomain.get_bridgedomains(self.cfg)
|
|
self.assertEqual(len(ifs), 3)
|