bb57ed8e52
Returns True if there is at most one occurence of the ip_interface (an IPv4/IPv6 prefix+len) in the entire config. That said, we need the 'iface_addresses' because VPP is a bit fickle in this regard. IP addresses from the same prefix/len can be added to a given interface (ie 192.0.2.1/24 and 192.0.2.2/24), but other than that, any prefix can not occur as a more-specific or less-specific of any other interface. So, we will allow: - any ip_interface that is of equal network/len of existing one(s) _on the same interface_ And, we will reject - any ip_interface that is a more specific of any existing one - any ip_interface that is a less specific of any existing one Update unit tests to ensure ip_interfaces are allowed in all cases.
83 lines
3.1 KiB
Python
83 lines
3.1 KiB
Python
#
|
|
# Copyright (c) 2022 Pim van Pelt
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at:
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
#
|
|
import logging
|
|
import validator.interface as interface
|
|
import validator.lcp as lcp
|
|
import validator.address as address
|
|
|
|
class NullHandler(logging.Handler):
|
|
def emit(self, record):
|
|
pass
|
|
|
|
|
|
def get_by_name(yaml, ifname):
|
|
""" Return the BridgeDomain by name, if it exists. Return None otherwise. """
|
|
try:
|
|
if ifname in yaml['bridgedomains']:
|
|
return yaml['bridgedomains'][ifname]
|
|
except:
|
|
pass
|
|
return None
|
|
|
|
|
|
def validate_bridgedomains(yaml):
|
|
result = True
|
|
msgs = []
|
|
logger = logging.getLogger('vppcfg.validator')
|
|
logger.addHandler(NullHandler())
|
|
|
|
if not 'bridgedomains' in yaml:
|
|
return result, msgs
|
|
|
|
logger.debug("Validating bridgedomains...")
|
|
for ifname, iface in yaml['bridgedomains'].items():
|
|
logger.debug("bridgedomain %s" % iface)
|
|
bd_mtu = 1500
|
|
if 'mtu' in iface:
|
|
bd_mtu = iface['mtu']
|
|
|
|
if 'addresses' in iface and not 'lcp' in iface:
|
|
msgs.append("bridgedomain %s has an address but no LCP" % ifname)
|
|
result = False
|
|
if 'lcp' in iface and not lcp.is_unique(yaml, iface['lcp']):
|
|
msgs.append("bridgedomain %s does not have a unique LCP name %s" % (ifname, iface['lcp']))
|
|
result = False
|
|
if 'addresses' in iface:
|
|
for a in iface['addresses']:
|
|
if not address.is_allowed(yaml, ifname, iface['addresses'], a):
|
|
msgs.append("bridgedomain %s IP address %s is not allowed" % (ifname, a))
|
|
result = False
|
|
|
|
if 'interfaces' in iface:
|
|
for member in iface['interfaces']:
|
|
member_iface = interface.get_by_name(yaml, member)
|
|
if not member_iface:
|
|
msgs.append("bridgedomain %s member %s doesn't exist" % (ifname, member))
|
|
result = False
|
|
continue
|
|
|
|
if interface.has_lcp(yaml, member):
|
|
msgs.append("bridgedomain %s member %s has an LCP" % (ifname, member))
|
|
result = False
|
|
if interface.has_address(yaml, member):
|
|
msgs.append("bridgedomain %s member %s has an address" % (ifname, member))
|
|
result = False
|
|
member_mtu = interface.get_mtu(yaml, member)
|
|
if member_mtu != bd_mtu:
|
|
msgs.append("bridgedomain %s member %s has MTU %d, while bridge has %d" % (ifname, member, member_mtu, bd_mtu))
|
|
result = False
|
|
|
|
|
|
return result, msgs
|