certificate-transparency/cheese
2
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Add Domain option to Log so that a custom domain can be specified #1

Closed
jeroen wants to merge 1 commits from custom-domain into main
pull from: custom-domain
merge into: certificate-transparency:main
Conversation 4 Commits 1 Files Changed 3 +18 -6
jeroen commented 2025-08-28 09:17:23 +00:00
Collaborator
Copy Link

Add Domain option to Log so that a custom domain can be specified :)

Add Domain option to Log so that a custom domain can be specified :)
jeroen added 1 commit 2025-08-28 09:17:24 +00:00
Add Domain option to Log so that a custom domain can be specified d2c564a000
jeroen requested review from pim 2025-08-28 09:17:24 +00:00
pim commented 2025-08-28 11:18:04 +00:00
Owner
Copy Link

I agree that hard coding *.ct.ipng.ch was a mistake, but I don't want another config option 'Domain' because we already have the monitoringprefix and submissionprefix. I think you can extract that hostname between https://(.*)/ instead.

That saves a redundant/repetitive config field, and removes ambiguity (is it mon.ct.ipng.ch or log.ct.ipng.ch?)

I agree that hard coding *.ct.ipng.ch was a mistake, but I don't want another config option 'Domain' because we already have the monitoringprefix and submissionprefix. I think you can extract that hostname between `https://(.*)/` instead. That saves a redundant/repetitive config field, and removes ambiguity (is it mon.ct.ipng.ch or log.ct.ipng.ch?)
jeroen commented 2025-08-28 12:39:14 +00:00
Author
Collaborator
Copy Link

I agree that hard coding *.ct.ipng.ch was a mistake, but I don't want another config option 'Domain' because we already have the monitoringprefix and submissionprefix. I think you can extract that hostname between https://(.*)/ instead.

That saves a redundant/repetitive config field, and removes ambiguity (is it mon.ct.ipng.ch or log.ct.ipng.ch?)

Should we then not simply have ShortName (halloumi2025h2) + Domain (ct.ipng.ch) and generate MonitoringPrefix + SubmissionPrefix from there? That is if we always put things in log + mon anyway and no path in the prefixes.

Or take the MonitoringPrefix, extract the ShortName + 'mon' subdomain, the remainder of of the hostname being the Domain?

(these are simple patches, thus will rebase the others when we settle on the answer ;) )

> I agree that hard coding *.ct.ipng.ch was a mistake, but I don't want another config option 'Domain' because we already have the monitoringprefix and submissionprefix. I think you can extract that hostname between `https://(.*)/` instead. > > That saves a redundant/repetitive config field, and removes ambiguity (is it mon.ct.ipng.ch or log.ct.ipng.ch?) Should we then not simply have ShortName (halloumi2025h2) + Domain (ct.ipng.ch) and generate MonitoringPrefix + SubmissionPrefix from there? That is if we always put things in log + mon anyway and no path in the prefixes. Or take the MonitoringPrefix, extract the ShortName + 'mon' subdomain, the remainder of of the hostname being the Domain? (these are simple patches, thus will rebase the others when we settle on the answer ;) )
pim commented 2025-08-28 18:16:15 +00:00
Owner
Copy Link

No, the origin is equal to the submissionprefix. You can simply replace the string directly like that, in other words, if submissionprefix: https://bla.example.com/ then the origin will be bla.example.com.
Further, you cannot hardcode 'mon' and 'log' either because those are choices we made for Cheese, not to be expected to be shared by everybody.
Lastly, I do not want to drift from the Sunlight yaml format if we can avoid it.

Why don't you synthesize a Log[i].Origin from submissionprefix and use that instead? Take a look at this diff to see what I have in mind as a counter offer.

No, the origin is equal to the submissionprefix. You can simply replace the string directly like that, in other words, if `submissionprefix: https://bla.example.com/` then the origin will be `bla.example.com`. Further, you cannot hardcode 'mon' and 'log' either because those are choices we made for Cheese, not to be expected to be shared by everybody. Lastly, I do not want to drift from the Sunlight yaml format if we can avoid it. Why don't you synthesize a Log[i].Origin from submissionprefix and use that instead? Take a look at [this diff](https://paste.ipng.ch/9ftu7l.txt) to see what I have in mind as a counter offer.
pim commented 2025-08-28 18:52:30 +00:00
Owner
Copy Link

I've decided to merge my diff instead of this approach, in 0503370. This PR can be reverted.

I've decided to merge my diff instead of this approach, in 0503370. This PR can be reverted.
pim closed this pull request 2025-08-28 18:52:30 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
pim
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
daknob jeroen pim
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: certificate-transparency/cheese#1
Delete Branch "custom-domain"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?