certificate-transparency/cheese
2
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

conf: Verify that loaded configuration has some validity #2

Open
jeroen wants to merge 3 commits from checkconf into main
pull from: checkconf
merge into: certificate-transparency:main
Conversation 2 Commits 3 Files Changed 4 +73 -11
jeroen commented 2025-08-28 10:05:17 +00:00
Collaborator
Copy Link

Verify that the config that is loaded has some sanity (at least a single log, various fields containing data, reporting when empty etc)

Maybe we might want to include a sample.yaml so it is easily adapted?

Verify that the config that is loaded has some sanity (at least a single log, various fields containing data, reporting when empty etc) Maybe we might want to include a sample.yaml so it is easily adapted?
jeroen added 3 commits 2025-08-28 10:05:17 +00:00
Add Domain option to Log so that a custom domain can be specified d2c564a000
key: Improve error message, including the log name for clarity 9db46db7ca
Verify that the config that is loaded has some sanity (at least a single log, various fields containing data, reporting when empty etc) 61097dc961
jeroen requested review from pim 2025-08-28 10:05:18 +00:00
pim commented 2025-08-28 11:19:48 +00:00
Owner
Copy Link

Looks good but you added the 'add domain option' commit, which is its own PR. Please remove it here. Otherwise, change looks good.

Looks good but you added the 'add domain option' commit, which is its own PR. Please remove it here. Otherwise, change looks good.
pim commented 2025-08-28 18:53:52 +00:00
Owner
Copy Link

If you can revert d2c564a000, the rest of this PR is good to go.

If you can revert d2c564a000, the rest of this PR is good to go.
This pull request has changes conflicting with the target branch.
  • tesseract/genconf/env.go
  • tesseract/genconf/html.go
  • tesseract/genconf/main.go
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin checkconf:checkconf
git checkout checkconf
Sign in to join this conversation.
Reviewers
No Reviewers
pim
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
daknob jeroen pim
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: certificate-transparency/cheese#2
No description provided.
Delete Branch "checkconf"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?