New feature: per-VIP / per-backend runtime counters
* New GetVPPLBCounters RPC serving an in-process snapshot refreshed
by a 5s scrape loop (internal/vpp/lbstats.go). Each cycle pulls
the LB plugin's four SimpleCounters (next, first, untracked,
no-server) plus the FIB /net/route/to CombinedCounter for every
VIP and every backend host prefix via a single DumpStats call.
* FIB stats-index discovery via ip_route_lookup (internal/vpp/
fibstats.go); per-worker reduction happens in the collector.
* Prometheus collector exports vip_packets_total (kind label),
vip_route_{packets,bytes}_total, and backend_route_{packets,
bytes}_total. Metrics source interface extended with VIPStats /
BackendRouteStats; vpp.Client publishes snapshots via
atomic.Pointer and clears them on disconnect.
* New 'show vpp lb counters' CLI command. The 'show vpp lbstate'
and 'sync vpp lbstate' commands are restructured under 'show
vpp lb {state,counters}' / 'sync vpp lb state' to make room
for the new verb.
New feature: src-ip-sticky frontends
* New frontend YAML key 'src-ip-sticky' (bool). Plumbed through
config.Frontend, desiredVIP, and the lb_add_del_vip_v2 call.
* Reflected in gRPC FrontendInfo.src_ip_sticky and VPPLBVIP.
src_ip_sticky, and shown in 'show vpp lb state' output.
* Scraped back from VPP by parsing 'show lb vips verbose' through
cli_inband — lb_vip_details does not expose the flag. The same
scrape also recovers the LB pool index for each VIP, which the
stats-segment counters are keyed on. This is a documented
temporary workaround until VPP ships an lb_vip_v2_dump.
* src_ip_sticky cannot be mutated on a live VIP, so a flipped flag
triggers a tear-down-and-recreate in reconcileVIP (ASes deleted
with flush, VIP deleted, then re-added). Flip is logged.
New feature: frontend state aggregation and events
* New health.FrontendState (unknown/up/down) and FrontendTransition
types. A frontend is 'up' iff at least one backend has a nonzero
effective weight, 'unknown' iff no backend has real state yet,
and 'down' otherwise.
* Checker tracks per-frontend aggregate state, recomputing after
each backend transition and emitting a frontend-transition Event
on change. Reload drops entries for removed frontends.
* checker.Event gains an optional FrontendTransition pointer;
backend- vs. frontend-transition events are demultiplexed on
that field.
* WatchEvents now sends an initial snapshot of frontend state on
connect (mirroring the existing backend snapshot), subscribes
once to the checker stream, and fans out to backend/frontend
handlers based on the client's filter flags. The proto
FrontendEvent message grows name + transition fields.
* New Checker.FrontendState accessor.
Refactor: pure health helpers
* Moved the priority-failover selector and the (pool idx, active
pool, state, cfg weight) → (vpp weight, flush) mapping out of
internal/vpp/lbsync.go into a new internal/health/weights.go so
the checker can reuse them for frontend-state computation
without importing internal/vpp.
* New functions: health.ActivePoolIndex, BackendEffectiveWeight,
EffectiveWeights, ComputeFrontendState. lbsync.go now calls
these directly; vpp.EffectiveWeights is a thin wrapper over
health.EffectiveWeights retained for the gRPC observability
path. Fully unit-tested in internal/health/weights_test.go.
maglevc polish
* --color default is now mode-aware: on in the interactive shell,
off in one-shot mode so piped output is script-safe. Explicit
--color=true/false still overrides.
* New stripHostMask helper drops /32 and /128 from VIP display;
non-host prefixes pass through unchanged.
* Counter table column order fixed (first before next) and
packets/bytes columns renamed to fib-packets/fib-bytes to
clarify they come from the FIB, not the LB plugin.
Docs
* config-guide: document src-ip-sticky, including the VIP
recreate-on-change caveat.
* user-guide, maglevc.1, maglevd.8: updated command tree, new
counters command, color defaults, and the src-ip-sticky field.
160 lines
4.5 KiB
Go
160 lines
4.5 KiB
Go
// Copyright (c) 2026, Pim van Pelt <pim@ipng.ch>
|
|
|
|
package main
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestExpandPathsRoot(t *testing.T) {
|
|
root := buildTree()
|
|
lines := expandPaths(root, "", make(map[*Node]bool))
|
|
|
|
// Should include well-known leaf paths.
|
|
want := []string{
|
|
"show version",
|
|
"show frontends",
|
|
"show frontends <name>",
|
|
"show backends",
|
|
"show backends <name>",
|
|
"show healthchecks",
|
|
"show healthchecks <name>",
|
|
"set backend <name> pause",
|
|
"set backend <name> resume",
|
|
"set backend <name> disable",
|
|
"set backend <name> enable",
|
|
"set frontend <name> pool <pool> backend <backend> weight <weight>",
|
|
"watch events",
|
|
"watch events <opt>",
|
|
"config check",
|
|
"show vpp info",
|
|
"show vpp lb state",
|
|
"show vpp lb counters",
|
|
"config reload",
|
|
"sync vpp lb state",
|
|
"sync vpp lb state <name>",
|
|
"quit",
|
|
"exit",
|
|
}
|
|
|
|
paths := make(map[string]bool, len(lines))
|
|
for _, l := range lines {
|
|
paths[l.path] = true
|
|
}
|
|
|
|
for _, w := range want {
|
|
if !paths[w] {
|
|
t.Errorf("expandPaths(root) missing %q", w)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestExpandPathsShow(t *testing.T) {
|
|
root := buildTree()
|
|
showNode, _ := Walk(root, []string{"show"})
|
|
lines := expandPaths(showNode, "show", make(map[*Node]bool))
|
|
|
|
for _, l := range lines {
|
|
if !strings.HasPrefix(l.path, "show ") {
|
|
t.Errorf("unexpected path %q: should start with 'show '", l.path)
|
|
}
|
|
if l.help == "" {
|
|
t.Errorf("path %q has empty help", l.path)
|
|
}
|
|
}
|
|
// version, frontends, frontends <name>, backends, backends <name>,
|
|
// healthchecks, healthchecks <name>, vpp info, vpp lb state,
|
|
// vpp lb counters = 10 lines
|
|
if len(lines) != 10 {
|
|
t.Errorf("expected exactly 10 show subcommands, got %d", len(lines))
|
|
}
|
|
}
|
|
|
|
func TestExpandPathsNoCycles(t *testing.T) {
|
|
root := buildTree()
|
|
// watch events has a self-referencing slot; expandPaths must terminate.
|
|
watchEvents, _ := Walk(root, []string{"watch", "events"})
|
|
lines := expandPaths(watchEvents, "watch events", make(map[*Node]bool))
|
|
|
|
// Should produce exactly 2 lines: "watch events" and "watch events <opt>".
|
|
if len(lines) != 2 {
|
|
t.Errorf("watch events: expected 2 lines, got %d: %v", len(lines), lines)
|
|
}
|
|
}
|
|
|
|
func TestExpandPathsSetBackendName(t *testing.T) {
|
|
root := buildTree()
|
|
// Walk to the name slot so displayPrefix carries the actual arg.
|
|
node, _ := Walk(root, []string{"set", "backend", "mybackend"})
|
|
lines := expandPaths(node, "set backend mybackend", make(map[*Node]bool))
|
|
|
|
want := []string{
|
|
"set backend mybackend pause",
|
|
"set backend mybackend resume",
|
|
"set backend mybackend disable",
|
|
"set backend mybackend enable",
|
|
}
|
|
if len(lines) != len(want) {
|
|
t.Fatalf("expected %d lines, got %d: %v", len(want), len(lines), lines)
|
|
}
|
|
for i, w := range want {
|
|
if lines[i].path != w {
|
|
t.Errorf("line %d: got %q, want %q", i, lines[i].path, w)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestPrefixMatchCollapsedNouns(t *testing.T) {
|
|
root := buildTree()
|
|
|
|
// "sh ba" → show backends (list all) via prefix matching.
|
|
node, args := Walk(root, []string{"sh", "ba"})
|
|
if node.Run == nil {
|
|
t.Fatal("'sh ba' did not reach a Run node")
|
|
}
|
|
if len(args) != 0 {
|
|
t.Errorf("'sh ba' should have 0 args, got %v", args)
|
|
}
|
|
|
|
// "sh ba nginx0" → show backends <name> (get specific) via slot.
|
|
node, args = Walk(root, []string{"sh", "ba", "nginx0"})
|
|
if node.Run == nil {
|
|
t.Fatal("'sh ba nginx0' did not reach a Run node")
|
|
}
|
|
if len(args) != 1 || args[0] != "nginx0" {
|
|
t.Errorf("'sh ba nginx0' args: got %v, want [nginx0]", args)
|
|
}
|
|
|
|
// "sh fr" → show frontends (list all).
|
|
node, _ = Walk(root, []string{"sh", "fr"})
|
|
if node.Run == nil {
|
|
t.Fatal("'sh fr' did not reach a Run node")
|
|
}
|
|
|
|
// "sh he icmp" → show healthchecks icmp (get specific).
|
|
node, args = Walk(root, []string{"sh", "he", "icmp"})
|
|
if node.Run == nil {
|
|
t.Fatal("'sh he icmp' did not reach a Run node")
|
|
}
|
|
if len(args) != 1 || args[0] != "icmp" {
|
|
t.Errorf("'sh he icmp' args: got %v, want [icmp]", args)
|
|
}
|
|
}
|
|
|
|
func TestExpandPathsWeightSlotWalk(t *testing.T) {
|
|
// Verify the weight command is fully walkable (fixes bug: setWeightValue
|
|
// and setFrontendPoolName were non-slot nodes that couldn't capture tokens).
|
|
root := buildTree()
|
|
node, args := Walk(root, []string{"set", "frontend", "web", "pool", "primary", "backend", "be0", "weight", "42"})
|
|
if node.Run == nil {
|
|
t.Fatal("Walk did not reach a Run node for full weight command")
|
|
}
|
|
if len(args) != 4 {
|
|
t.Errorf("expected 4 args (name, pool, backend, weight), got %d: %v", len(args), args)
|
|
}
|
|
if args[3] != "42" {
|
|
t.Errorf("args[3] (weight): got %q, want 42", args[3])
|
|
}
|
|
}
|