Commit Graph

46 Commits

Author SHA1 Message Date
5e11539b44 Format with black 2023-01-08 13:05:42 +01:00
72e9cf3503 Update README.md 2022-12-23 16:01:02 +01:00
a56840d849 Update README.md 2022-12-23 10:20:11 +01:00
cde5d4df94 Update README.md 2022-12-23 10:09:06 +01:00
16c29e0ce6 Allow vppapi!=vppstats count, continue and use those interfaces that are in the API 2022-07-10 20:49:44 +00:00
b4c819af87 Retrieve description from all interface types, not just ethernets 2022-07-10 11:33:47 +00:00
b024a3e96b Move the YAML config to be compatible with vppcfg's config file 2022-07-10 09:47:33 +00:00
3be732e6ab Remove the workaround for endianness in VPP; Remove the --disable-lcp flag. Catch connect exceptions for VPPStats and VPP API 2022-07-09 10:14:15 +00:00
c9233749bc Pulled in latest vpp_stats.py from upstream after https://gerrit.fd.io/r/c/vpp/+/35640 2022-04-01 13:10:17 +00:00
968c0abe2f Fail the setup if we can't connect to VPP; exit the daemon with non-zero value to force restart by systemd 2022-03-14 23:14:59 +00:00
86512dd66b Turn interface mismatch into a warning - it is often recoverable 2022-03-13 12:05:54 +00:00
c112016665 Add a flag to disable lcp lookups, due to pending VAPI issues (https://gerrit.fd.io/r/c/vpp/+/35479) 2022-03-08 13:25:29 +00:00
a9c9e15828 typo fix 2022-02-27 23:01:19 +00:00
f97f50bf30 Update README 2022-02-27 22:59:55 +00:00
c319ef576d Add an optional configuration file
A simple convenience configfile can provide a mapping between VPP
interface names, Linux Control Plane interface names, and descriptions.
An example:

```
interfaces:
  "TenGigabitEthernet6/0/0":
    description: "Infra: xsw0.chrma0:2"
    lcp: "xe1-0"
  "TenGigabitEthernet6/0/0.3102":
    description: "Infra: QinQ to Solnet for Daedalean"
    lcp: "xe1-0.3102"
  "TenGigabitEthernet6/0/0.310211":
    description: "Cust: Daedalean IP Transit"
    lcp: "xe1-0.3102.11"
```

This configuration file is completely optional. If the `-c` flag is
empty, or it's set but the file does not exist, the Agent will simply
enumerate all interfaces, and set the `ifAlias` OID to the same value
as the `ifName`. However, if the config file is read, it will change
the behavior as follows:

*  Any `tapNN` interface names from VPP will be matched to their PHY by
   looking up their Linux Control Plane interface. The `ifName` field
   will be rewritten to the _LIP_ `host-if`. For example, `tap3` above
   will become `xe1-0` while `tap3.310211` will become `xe1-0.3102.11`.
*  The `ifAlias` OID for a PHY will be set to the `description` field.
*  The `ifAlias` OID for a TAP will be set to the string `LCP: `
   followed by its PHY `ifName`. For example, `xe1-0.3102.11` will
    become `LCP TenGigabitEthernet6/0/0.310211 (tap9)`
2022-02-27 22:58:03 +00:00
80190bf2d0 Merge pull request #1 from amartin-git/patch-1
Set larger receive buffer size for bulk requests
2021-12-06 18:30:29 +01:00
c19df5a77a Set larger receive buffer size for bulk requests
When using SNMP BULK GET requests (from Zabbix in our case), the default value of 1024 truncates the request, resulting in malformed requests reaching the agent. Using an 8K buffer fixes this. A better approach perhaps would be to process the buffer using a loop.
2021-12-06 12:26:22 -05:00
89abebb26b Merge branch 'main' of github.com:pimvanpelt/vpp-snmp-agent into main 2021-09-15 08:02:26 +00:00
18005bbbc2 Fix memory leak in logging (specifically: do not create a new logger for every SNMP PDU) 2021-09-15 07:58:08 +00:00
a574305fb2 Reconnect faster after errors (0.1s sleep) 2021-09-15 07:57:17 +00:00
09a2b6e9e4 Remove logger from dataset, it's not necessary, as there's only one call location that wants to say something. Turn that into an exception instead 2021-09-15 07:56:50 +00:00
bf9d61b95d Restart snmpd if it fails 2021-09-13 07:54:13 +02:00
610d03a14b Refactor README.md 2021-09-12 16:31:13 +00:00
5051ab32ce Update README with the -h/--help argparse hint 2021-09-12 16:22:22 +00:00
6d0ed88722 Add argparse and a few useful arguments
Now that we're explicitly connecting via TCP to localhost:705 (which
can be overriden by the -a flag), we no longer need to run as root.
Therefore, update vpp-snmp-agent.service to run as user Debian-snmp
group vpp, so that /run/vpp/{api,stats}.sock are writable.
Be explicit on the commandline arguments in the service definition.
2021-09-12 16:19:33 +00:00
7206d92f40 Move all loggers to be members of the class, not global objects 2021-09-12 16:08:35 +00:00
9265e211e3 Swap oper/admin status (they were the wrong way around) 2021-09-12 14:09:23 +00:00
96f2a3b4b3 Move to /usr/sbin instead of /usr/local/sbin 2021-09-11 12:55:28 +00:00
c72890868c s/freq/period/ to be more precies; Set default period to 30s; set wait period on reconnect to 10s; Add explicit INFO logline when replacing dataset 2021-09-11 12:45:28 +00:00
8c9c1e2b4a Replace the pyagentx threaded version with a much simpler, non-threaded version. 2021-09-11 12:19:38 +00:00
842bce9d6e Add server_address to initializer, allow for unix path (starts with /) or hostname:port address 2021-09-11 08:13:21 +00:00
0c0e4fc14a A better way to specify netns
See docs:

https://www.freedesktop.org/software/systemd/man/systemd.exec.html#NetworkNamespacePath=
2021-09-05 21:02:11 +00:00
184d2eceb2 Restart agent on failure 2021-09-05 20:26:47 +00:00
9b39aa61c2 Clamp all COUNTER32 at mod 2^32 2021-09-05 20:15:06 +00:00
7dec1329d2 Turn VPPApi into a threadsafe object
It now is tolerant to VPP restarts. Upon initialization, we connect(),
blocking all but the first thread from trying. The rest will see
self.connected=True and move on.

Then, on each/any error, call vpp.disconect() and set connected=False
which will make any subsequent AgentX updater run force a reconnect.
2021-09-05 20:02:11 +00:00
e1cddc8c26 Add VPP API support to retrieve mtu/ifspeed/operstatus/adminstatus/mac 2021-09-05 19:39:20 +00:00
238471d25f Ensure more updates can fit in the queue, allow scaling to 20 variables on 1000 interfaces 2021-09-05 18:23:23 +00:00
2e7aa607e4 Add most of the standard (32bit) ifTable.ifEntry MIB, the 5 that are left will require vpp_papi support, coming next 2021-09-05 18:12:02 +00:00
ac8c323abf Ensure VPPStat() is connected before each read; if VPP restarts, we'll lose the connection, and this ensures that once VPP comes back up, we'll re-connect to it seemlessly 2021-09-05 16:19:44 +00:00
21f2e9dc72 format yapf 2021-09-05 16:14:11 +00:00
7afd82c928 Remove cache, read directly and constantly from MMAP -- the update threads only fire every 10s anyway; so even a hammering snmp client won't interact with VPP more than once-per-10s 2021-09-05 16:11:23 +00:00
80bbc754e4 Consistently clear ifstat members 2021-09-05 15:47:15 +00:00
8256c6abfc Update README with build/run instructions 2021-09-05 15:39:26 +00:00
a621d560cd Correct enumeration off-by-one; OID .14 doesn't exist 2021-09-05 15:26:13 +00:00
954fd2e5b6 Run as root 2021-09-05 15:25:54 +00:00
51eee915bf initial checkin 2021-09-05 15:13:12 +00:00