Move LCP tests to their own test_*py file

This commit is contained in:
Pim van Pelt
2022-03-20 22:01:51 +00:00
parent 459346878a
commit 14cd365ad3
2 changed files with 15 additions and 6 deletions

View File

@ -1,7 +1,6 @@
import unittest import unittest
import yaml import yaml
import validator.interface as interface import validator.interface as interface
import validator.lcp as lcp
class TestInterfaceMethods(unittest.TestCase): class TestInterfaceMethods(unittest.TestCase):
def setUp(self): def setUp(self):
@ -77,11 +76,6 @@ class TestInterfaceMethods(unittest.TestCase):
self.assertEqual(interface.get_lcp(self.cfg, "GigabitEthernet1/0/1"), "e1") self.assertEqual(interface.get_lcp(self.cfg, "GigabitEthernet1/0/1"), "e1")
self.assertEqual(interface.get_lcp(self.cfg, "GigabitEthernet1/0/1.100"), "foo") self.assertEqual(interface.get_lcp(self.cfg, "GigabitEthernet1/0/1.100"), "foo")
self.assertTrue(lcp.is_unique(self.cfg, "e1"))
self.assertTrue(lcp.is_unique(self.cfg, "foo"))
## TODO(pim) - ensure that is_unique also takes synthesized LCPs into account
## self.assertFalse(lcp.is_unique(self.cfg, "e1.1000"))
self.assertEqual(interface.get_lcp(self.cfg, "GigabitEthernet1/0/1.200"), "e1.1000") self.assertEqual(interface.get_lcp(self.cfg, "GigabitEthernet1/0/1.200"), "e1.1000")
self.assertEqual(interface.get_lcp(self.cfg, "GigabitEthernet1/0/1.201"), "e1.1000") self.assertEqual(interface.get_lcp(self.cfg, "GigabitEthernet1/0/1.201"), "e1.1000")

15
validator/test_lcp.py Normal file
View File

@ -0,0 +1,15 @@
import unittest
import yaml
import validator.lcp as lcp
class TestInterfaceMethods(unittest.TestCase):
def setUp(self):
with open("unittest/TestInterfaceMethods.yaml", "r") as f:
self.cfg = yaml.load(f, Loader = yaml.FullLoader)
def test_lcp(self):
self.assertTrue(lcp.is_unique(self.cfg, "e1"))
self.assertTrue(lcp.is_unique(self.cfg, "foo"))
## TODO(pim) - ensure that is_unique also takes synthesized LCPs into account
## self.assertFalse(lcp.is_unique(self.cfg, "e1.1000"))