- Zurich, Switzerland
- https://ipng.ch/
- Joined on
2022-07-26
Block a user
conf: Verify that loaded configuration has some validity
If you can revert d2c564a000, the rest of this PR is good to go.
Add Domain option to Log so that a custom domain can be specified
Add Domain option to Log so that a custom domain can be specified
I've decided to merge my diff instead of this approach, in 0503370. This PR can be reverted.
Add Domain option to Log so that a custom domain can be specified
No, the origin is equal to the submissionprefix. You can simply replace the string directly like that, in other words, if submissionprefix: https://bla.example.com/
then the origin will be…
conf: Verify that loaded configuration has some validity
Looks good but you added the 'add domain option' commit, which is its own PR. Please remove it here. Otherwise, change looks good.
Add Domain option to Log so that a custom domain can be specified
I agree that hard coding *.ct.ipng.ch was a mistake, but I don't want another config option 'Domain' because we already have the monitoringprefix and submissionprefix. I think you can extract that…